Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the current extension popup when using ShowActionUI (uplift to 1.21.x) #7945

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Hide the current extension popup when using ShowActionUI (uplift to 1.21.x) #7945

merged 1 commit into from
Feb 12, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 12, 2021 •
edited by kjozwiak
Loading

Uplift of #7935
Resolves brave/brave-browser#14110
Resolves brave/brave-browser#14108

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 12, 2021 13:56
@brave-builds brave-builds requested review from emerick, zenparsing and a team and removed request for a team February 12, 2021 13:56
@brave-builds brave-builds self-assigned this Feb 12, 2021
@brave-builds brave-builds added this to the 1.21.x - Beta milestone Feb 12, 2021
kjozwiak
kjozwiak approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#14110 (comment) & brave/brave-browser#14108 (comment).

@kjozwiak kjozwiak merged commit 64f63d7 into 1.21.x Feb 12, 2021
@kjozwiak kjozwiak deleted the pr7935_ksmith-bap-ui-crash_1.21.x branch February 12, 2021 22:45
bsclifton added a commit that referenced this pull request Feb 26, 2021
@bsclifton
Revert "Merge pull request #7945 from brave/pr7935_ksmith-bap-ui-cras…
706d689 
…h_1.21.x"

This reverts commit 64f63d7, reversing
changes made to 96e3378.
tmancey pushed a commit that referenced this pull request Oct 25, 2023
@StephenHeaps
Fix #7945: NFTs displayed in Portfolio when grouped by accounts (#8300)
b0f6da4 
Make sure NFTs filtered out when grouping by accounts; resolves NFTs displaying in account groups & possible graph issues (NFT dependent)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@emerick emerick Awaiting requested review from emerick

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases